[Stgt-devel] Implementation of vtl

FUJITA Tomonori fujita.tomonori
Wed Jul 16 10:32:51 CEST 2008

On Wed, 7 May 2008 18:22:45 +1000
"Mark Harvey" <markh794 at gmail.com> wrote:

> Hello aftab azmi,
> First off, thanks... You beat me to the punch :) It might save me some work....
> While I can't speak authoritatively, I'm sure this will be rejected
> first off due the the code base not following the Linux kernel coding
> style... You can find the coding style document in the Linux kernel
> source under the Documentation dir.
> I've passed it thru the scripts/checkpatch.pl script and attached are
> the coding style errors: (Lots of tab/space issues)
> 2nd. The 'detection' of a filemark appears a little week. i.e. first
> byte at a 512 byte boundary to contain '28'. This could produce many
> false positives.
> 3rd. I see no way to detect variable block underrun/overrun detection
> (the main sticking point with my code base)..
> 4th. You assume variable block writes. This code would fail if the
> user set the tape block size to 'fixed block'.
> Point 1 is easily resolved with a little effort.

ok, I did:


> Do you have any ideas on the solution to points 2 & 3 (just not coded yet) ?

We need kinda metadata, which can be a separate file or can be placed
in a file storing the contents?

More information about the stgt mailing list