[Stgt-devel] [PATCH] Use correct return value of lseek
Sat Jul 19 18:49:00 CEST 2008
FUJITA Tomonori wrote:
> On Fri, 18 Jul 2008 18:37:24 +0200
> Albert Pauw <albert.pauw at gmail.com> wrote:
>> Just a small patch.
>> The wrong return value was checked in the if statement.
>> --- bs_ssc.c 2008-07-17 19:19:10.000000000 +0200
>> +++ bs_ssc.c.new 2008-07-18 18:34:15.000000000 +0200
>> @@ -65,7 +65,7 @@
>> case REZERO_UNIT:
>> rew = lseek(fd, 0, SEEK_SET);
>> curr_pos = lseek(fd, 0, SEEK_CUR);
>> - if (ret)
>> + if (rew)
>> set_medium_error(&result, &key, &asc);
>> eprintf("Rewind Successful, File Pointer at %" PRIu64",%m\n",
> I think that the fix is right but what's for the second lseek? Can we
> remove it?
I believe the second seek is put in to be used only by the eprintf
function, just to check the
current position and show that the seek was succesfull.
Since it is still work in progress and anything near finished I would
leave it in for the moment.
More information about the stgt