[Stgt-devel] [PATCH] add dumping current tgtd configuration in tgt-admin

[FUJITA Tomonori]

On Mon, 28 Jul 2008 10:08:55 +0200
Tomasz Chmielewski <mangoo at wpkg.org> wrote:

> FUJITA Tomonori schrieb:
> > On Fri, 25 Jul 2008 17:14:08 +0200
> > Tomasz Chmielewski <mangoo at wpkg.org> wrote:
> > 
> >> Add dumping current tgtd configuration to stdout in tgt-admin.
> >> The dumped config will not contain any passwords as tgtadm doesn't show 
> >> them, they are currently substituted with some BIG FAT words.
> >>
> >> It currently adds a "driver" config option to each target (i.e. driver 
> >> iscsi) in order to support more target types than just iscsi - I will 
> >> add support to it in the rest of tgt-admin next week.
> >>
> >>
> >> Signed-off-by: Tomasz Chmielewski (mangoo at wpkg.org)
> > 
> > Thanks!
> > 
> > But the patch is corrupted (tabs were replaced with spaces). Can you
> > resend a proper one (if you can't as a plain text, an attachment is
> > fine)?
> > 
> > I would appreciate if you could send a patch generated with git.
> 
> Here comes the git one:
> 
> 
> diff --git a/scripts/tgt-admin b/scripts/tgt-admin

Applied. Great, thanks a lot!

I think that it would be better to allow users to run this option
without a configuration file. (for now only the execute option
requires the configuration file, I guess).


I'd appreciate if you would run checkpatch.pl before submitting a
patch next time.