[Stgt-devel] [PATCH] tgt-admin: support persistent device binding

[FUJITA Tomonori]

On Mon, 28 Jul 2008 12:26:49 +0300
Doron Shoham <dorons at voltaire.com> wrote:

> sync this patch with the current git.
> The man page already have an example for using
> direct-device.
> I'll send a patch with an example of using
> serial number instead of /dev/sdX after this
> patch will be applied.
> Tomo - can u please explain me how to use
> git-am for checking my patches?
> I use checkpatch.pl script to check my patches.

viola:~/git/tgt$ git-am --whitespace=error your-patch.diff

BTW, this patch is fine.


> Signed-off-by: Doron Shoham <dorons at voltaire.com>
> ---
>  doc/manpages/tgt-admin.8 |    3 ++
>  scripts/tgt-admin        |   64 ++++++++++++++++++++++++++++++++++-----------
>  2 files changed, 51 insertions(+), 16 deletions(-)
> 
> diff --git a/doc/manpages/tgt-admin.8 b/doc/manpages/tgt-admin.8
> index 97d6484..5598932 100644
> --- a/doc/manpages/tgt-admin.8
> +++ b/doc/manpages/tgt-admin.8
> @@ -85,6 +85,9 @@ example for a configuration file:
>  <target iqn.2007-02.com.example:san.xen1>
>     backing-store /dev/san/xen1-disk1 # LUN1
>     direct-store /dev/san/xen1-disk2 # LUN2
> +   # for persistent binding use scsi serial number
> +   backing-store 00c0ffd508d70048ed1dbc4704000000 #LUN3
> +   direct-store 00c0ffd508d70048ed1dbc4704000001 # LUN4

I'm not sure about direct-store thing at all. They are
confusing. direct-store is backing-store.

Firstly, why can't we just use the same properties of a physical
device if an administrator puts a device file of a disk drive?

Secondly, why do we need to look for a disk drive whose SCSI ID that
an administrator specifies.

An administrator can just put device files that udev cleverly creates
in the configuration file:

 /dev/disk/by-id/scsi-SATA_WDC_WD5000AAKS-_WD-WCAS848