[Stgt-devel] [PATCH 2/7] Add option to delete all the targets

[Tomasz Chmielewski]

FUJITA Tomonori schrieb:

(...)

>> What is the preferred approach to delete the targets via tgt-admin?
>>
>> 1) delete only the targets which have no initiators connected - this is what we do right now; we offline them before we try to delete
>>
>> 2) delete ALL targets, even if initiators are connected (supported since "support to close a connection by force and to shut down tgtd")

(...)

> I think that the majority of administrators will use a user-friendly
> tool like tgt-admin (possible alternatives are web interface, or shell
> interface as many appliances do). So I expect people want to do common
> operations with it. The above two operations are often used, I guess.

IMHO it would make sense to make two "delete" options then:

--delete <ALL|tid=|targetname>

It would only touch the target if it is not in use.
ALL would delete all targets which are not in use; the targets which have initiators connected would not have its state changed (some informational message would be displayed to the user).

--forcedelete <ALL|tid=|targetname>

It would delete the targets irrespectively of their use.


-- 
Tomasz Chmielewski 
http://wpkg.org