[Stgt-devel] [PATCH] Proof of Concept -> Separate thread init/tear-down from backing store open/close.

[FUJITA Tomonori]

On Wed, 30 Jul 2008 10:00:28 -0700
"Richard Sharpe" <realrichardsharpe at gmail.com> wrote:

> On Wed, Jul 30, 2008 at 12:44 AM, Mark Harvey <markh794 at gmail.com> wrote:
> > Patch also included as an attachment - just in case.
> >
> >> From 715e434fff633ff8f346d181aeae3f27c9564553 Mon Sep 17 00:00:00 2001
> >
> > From: Mark Harvey <markh794 at gmail.com>
> > Date: Wed, 30 Jul 2008 17:27:28 +1000
> > Subject: Separate thread init/tear-down from backing store open/close.
> >
> > Fix segfault when lu created without a backing store.
> > - Devices defined as 'removable' are able to be configured without a backing
> >  store defined.
> > - thread init via bs_init() which is called for all logical units
> > - thread tear-down via bs_exit() which is called for all logical units.
> > - bs_open() limited to opening backing store path (called when required).
> > - bs_close() limited to closing backing store fd (called when required).
> 
> Well, it's certainly a larger patch than the one I provided, but it
> does also seem to fix the problem I forgot about (threads laying
> around after a tape is moved out of the virtual drive).

As I wrote in the previous mail, I think that your approach works and
it's fine by me. But Mark sent a patch to do the right things so let's
go with that approach.