[Stgt-devel] Patches for MMC and fix for serious crash bug in spc_mode_sense()

ronnie sahlberg ronniesahlberg
Sat May 3 04:00:58 CEST 2008


do you want me to resend these 7 patches in that way as separate mails?


On Sat, May 3, 2008 at 11:32 AM, FUJITA Tomonori
<fujita.tomonori at lab.ntt.co.jp> wrote:
> On Fri, 2 May 2008 22:55:22 +1000
> "ronnie sahlberg" <ronniesahlberg at gmail.com> wrote:
>
>> Please disregard the previous pathset
>>
>> Please find attached a patchset that contains
>>
>> 0001 fix a bug in mode sense 10  where the data length is 1 too little
>> 0002 dont set modepages in the example, these pages are created by
>> default when the lun is created anyway
>> 0003 add modepage for mm capabilities
>> 0004 fix crashbug in spc_mode_sense()    if an application is asking
>> for mode sense and specifies a small allocation length,
>> spc_mode_sense() and build_mode_page() would write beyond the end of
>> the data array and overwrite other things causing tgtd to crash
>> has probably not been seen before since prior to 0003 above, there
>> hasnt been any very large mode pages   and tgtd just must have been
>> lucky.
>> 0005 mode page for write parameters
>> 0006 example on how to use dvdrecorder under linux with the emulation
>> 0007 final fix so that both windows dvddecrypter and also linux
>> dvdrecorder can write to the emulated lun
>
> Thanks,
>
> Can you send patches as just plain text (one patch per email)? Then
> wee can read and comment on your patches.
>
> If you are not familiar with the way to send patches in Linux kernel
> way, the followings would help:
>
> http://linux.yyz.us/patch-format.html
> http://lxr.linux.no/linux/Documentation/SubmittingPatches
>



More information about the stgt mailing list