[Stgt-devel] [PATCH 1/1] mmc: unit serial number fix

[FUJITA Tomonori]

On Wed, 7 May 2008 06:27:25 +1000
"ronnie sahlberg" <ronniesahlberg at gmail.com> wrote:

> >From 4f5391a1c67e69d913163c9dcf168cdf39229ad9 Mon Sep 17 00:00:00 2001
> From: Ronnie Sahlberg <ronniesahlberg at gmail.com>
> Date: Wed, 7 May 2008 06:18:55 +1000
> Subject: [PATCH] Use same serial num in getconfig:unitserialnum as inquiry does
> 
> The feature GetConfiguration/Lun_Serial_Number is used to pull
> the unit serial number from a device.
> Use the same data that inq 0x80 uses to report the serial number
> so that both methods (getconf and inq) report the same serial number
> for the device.
> 
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg at gmail.com>
> ---
>  usr/mmc.c |   19 ++++++++++---------
>  1 files changed, 10 insertions(+), 9 deletions(-)

The patch is corrupt. If you use gmail via the web interface, you
can't post patches properly, I guess (if you use gmail via pop/smtp,
it would be fine).

There is one style problem too.

I fixed them and merged the patch.

Thanks,

fujita at arbre:~/git/tgt$ ./scripts/checkpatch.pl ~/Mail/iscsi/stgt/2621
ERROR: patch seems to be corrupt (line wrapped?)
#82: FILE: usr/mmc.c:832:
*cmd, char *data,

ERROR: patch seems to be corrupt (line wrapped?)
#93: FILE: usr/mmc.c:845:
scsi_cmd *cmd, char *data,

WARNING: braces {} are not necessary for single statement blocks
#109: FILE: usr/mmc.c:852:
+       if (vpd_pg->size == 8) {
+               memcpy(data, vpd_pg->data, 8);
+       }

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.