[Stgt-devel] [PATCH spc 1/1] RESEND Add service action framework

[FUJITA Tomonori]

On Mon, 26 May 2008 15:10:13 +1000
"ronnie sahlberg" <ronniesahlberg at gmail.com> wrote:

> Find attached a patch that adds a "service action" framework to stgt
> and as an example
> adds MaintenanceIn/ReportSupportedOpcodes (0xa3/0x0c).
> 
> Patch is also attached in gzip format if gmail decides to mangle the
> pasted text.
> 
> I have reworked the patch and implemented the changes suggested.
> 
> regards
> ronnie sahlberg
> 
> 
> >From 58bbd3fa1ee8f05ed82071c2939fd48e507797a8 Mon Sep 17 00:00:00 2001
> From: Ronnie Sahlberg <ronniesahlberg at gmail.com>
> Date: Mon, 26 May 2008 14:55:50 +1000
> Subject: [PATCH 1/1] add infrastructure to handle commands taking
> service actions
> 
> implement Maintenance / ReportAllSupportedOpcodes as an example
> 
> Expand device_type_operations to also include a list of possible service
> actions for this cdb. We need to know how many/what service actions
> a certain cdb can take in order to be able to report
> SupportedOpcodes properly. (MaintIn/service action 0x0c)
> 
> Implement MaintenanceIn and implement service action 0x0c for this command.
> the provided infrastructure should make it easier to add other MaintIn
> service actions, of which there are quite a few.
> 
> there are many other opcodes that also take service actions and which
> could build on this framework:
> 0xa4 MaintOut
> 0x7f: variable length cdb
> 0x5e/0x5f persistent reservarion in/out
> 0xab
> 0x9e
> 0x9f
> 
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg at gmail.com>
> ---
>  usr/sbc.c  |    2 +-
>  usr/scc.c  |    2 +-
>  usr/scsi.c |   10 ++++
>  usr/smc.c  |    2 +-
>  usr/spc.c  |  170 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  usr/spc.h  |    2 +
>  usr/tgtd.h |    8 +++
>  7 files changed, 193 insertions(+), 3 deletions(-)

Looks great, applied.

Thanks,