[stgt] [PATCH 08/15] ssc: remove obsolete comments

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Sun Oct 5 16:37:38 CEST 2008


Now ssc backing store code uses only one thread so no need to worry
about metadata locking.

Signed-off-by: FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp>
---
 usr/bs_ssc.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/usr/bs_ssc.c b/usr/bs_ssc.c
index e1ca4d8..a685673 100644
--- a/usr/bs_ssc.c
+++ b/usr/bs_ssc.c
@@ -60,7 +60,6 @@ static int skip_next_header(struct scsi_lu *lu)
 	struct ssc_info *ssc = dtype_priv(lu);
 	struct blk_header *h = ssc->c_blk;
 
-	/* FIXME: Need a lock around this read */
 	rd = pread(lu->fd, h, sizeof(struct blk_header), h->next);
 	if (rd != sizeof(struct blk_header))
 		return 1;
@@ -73,7 +72,6 @@ static int skip_prev_header(struct scsi_lu *lu)
 	struct ssc_info *ssc = dtype_priv(lu);
 	struct blk_header *h = ssc->c_blk;
 
-	/* FIXME: Need a lock around this read */
 	rd = pread(lu->fd, h, sizeof(struct blk_header), h->prev);
 	if (rd != sizeof(struct blk_header))
 		return 1;
@@ -130,7 +128,6 @@ static int append_blk(struct scsi_cmd *cmd, uint8_t *data,
 			ssc->c_blk->blk_type, ssc->c_blk->blk_num,
 			ssc->c_blk->ondisk_sz, size);
 
-	/* FIXME: Need lock protection around this */
 	curr = ssc->c_blk;
 	curr->next = curr->curr + size + sizeof(struct blk_header);
 	curr->blk_type = type;
@@ -146,7 +143,6 @@ static int append_blk(struct scsi_cmd *cmd, uint8_t *data,
 	eod->a = 'A';
 	eod->z = 'Z';
 	ssc->c_blk = eod;
-	/* End of protection */
 
 	eprintf("After update  : prev/curr/next"
 		" <%" PRId64 "/%" PRId64 "/%" PRId64 "> type: %d,"
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list