[stgt] [PATCH] check for valid parameters when passing tgtadm commands
Doron Shoham
dorons at Voltaire.COM
Wed Oct 15 14:39:25 CEST 2008
> Please fix the following checkpatch errors and resend an updated
> patch:
>
> fujita at arbre:~/git/tgt$ ./scripts/checkpatch.pl ~/Mail/iscsi/stgt/3410
> WARNING: multiple assignments should be avoided
> #113: FILE: usr/tgtadm.c:390:
> + total = cid = hostno = sid = lun = rc = 0;
>
> ERROR: do not use assignment in if condition
> #170: FILE: usr/tgtadm.c:514:
> + if ((rc = verify_mode_params(argc, argv, "LmotT"))) {
>
> WARNING: line over 80 characters
> #176: FILE: usr/tgtadm.c:520:
> + eprintf("creating a new target needs the name\n");
>
do we follow the above coding style of 80 characters per line?
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the stgt
mailing list