[stgt] segfault when stopping the target

[FUJITA Tomonori]

On Tue, 21 Oct 2008 17:06:41 +0200
Tomasz Chmielewski <mangoo at wpkg.org> wrote:

> FUJITA Tomonori schrieb:
> > On Tue, 21 Oct 2008 16:23:02 +0200
> > Tomasz Chmielewski <mangoo at wpkg.org> wrote:
> > 
> >> FUJITA Tomonori schrieb:
> >>
> >>>>>> --- SIGSEGV (Segmentation fault) @ 0 (0) ---
> >>>>>> +++ killed by SIGSEGV +++
> >>>>>> Process 5131 detached
> >>>>> This helps?
> >>>> At least it does not crash any more ;)
> >>>> But it loops endlessly.
> >>> Ah, thanks.
> >>>
> >>> With this patch, tgtadm should fail properly instead of going into
> >>> endless loop.
> >>>
> >>> But we need to know why tgtd closed tgtadm's socket. Can you try this
> >>> patch and let me know if you get error messages in the log.
> >> It does not seem to crash nor loop any more.
> > 
> > Nice.
> > 
> >> Does it say anything?
> >>
> >> Oct 21 16:21:04 megathecus tgtd: conn_close_force(197) close 1 0
> >> Oct 21 16:21:04 megathecus tgtd: conn_close(88) connection closed 0x80700b4 4
> >> Oct 21 16:21:04 megathecus tgtd: tgt_event_modify(159) Cannot find event 7
> > 
> > Can you try this new patch and send messages in the log?
> > 
> > I expect error messages like:
> > 
> > tgtd: mtask_handler(x) hoge
> > tgtd: mgmt_event_handler(x) hoge
> 
> This:
> 
> tgtadm --op update --mode target --tid=1 -n state -v offline
> tgtadm --op update --mode sys --name State -v offline
> tgtadm --op unbind --mode target --tid 1 -I ALL
> tgtadm --op delete --mode conn --tid 1 --sid 3 --cid 0
> tgtadm --mode target --op delete --tid=1
> 
> 
> gave this log:
> 
> Oct 21 17:03:55 megathecus tgtd: conn_close_force(197) close 3 0
> Oct 21 17:03:55 megathecus tgtd: conn_close(88) connection closed 0x80700b4 2
> Oct 21 17:03:55 megathecus tgtd: tgt_event_modify(159) Cannot find event 7
> Oct 21 17:03:55 megathecus tgtd: tgt_target_destroy(1739) target 1 still has it nexus

Did you get a message earlier like

tgtd: mgmt_event_handler(504) new ipc connection 5

Note that the last number is probably a different value (not 5).


> 
> I applied to latest patch against git (so, without earlier patches, and 
> without a tgtd.c patch) - is it OK?

Yeah, the latest patch is against the current git. Please apply only
the latest patch and ignore the earlier patches (sorry for forgetting
to mention it).
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html