[stgt] [PATCH] fix tid testing

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Thu Oct 23 02:14:54 CEST 2008


On Wed, 22 Oct 2008 10:08:20 +0200
Doron Shoham <dorons at Voltaire.COM> wrote:

> return error if tid is not a postive integer
> 
> Signed-off-by: Doron Shoham <dorons at voltaire.com>

In general, this patch does the right things:

1. we do more strict checking
2. we create a target whose id is 0.

But I'm a bit worry about the latter change since I guess that some
parts of the code assume that zero tid is an error.

If you are confident that all the code can handle zero tid, it's
fine. But if not, please change this patch to handle zero tid as an
error.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list