[stgt] [PATCH 2/2] tgt-admin: check if device is mounted on /

[FUJITA Tomonori]

On Fri, 12 Sep 2008 09:59:26 +0200
Tomasz Chmielewski <mangoo at wpkg.org> wrote:

> FUJITA Tomonori schrieb:
> > On Thu, 11 Sep 2008 17:33:14 +0300
> > Doron Shoham <dorons at Voltaire.COM> wrote:
> > 
> >> deny allocation of a device which
> >> mounted on the same device as rootfs.
> >> also deny the allocation of swap devices.
> >> using --force flag for overriding this.
> >>
> >> Signed-off-by: Doron Shoham <dorons at voltaire.com>
> >> ---
> >>  scripts/tgt-admin |   87 +++++++++++++++++++++++++++++++++++++++++++++++++----
> > 
> > Thanks, sounds good. Any objection against this patch?
> 
> I'm still not persuaded that it's the right approach.
> 
> I.e., let's say we have a device which is always in use, but we want 
> tgtd to use it.
> 
> With current approach, we have to start tgt-admin several times:
> 
> 1) Lets start all targets:
> 
> # tgt-admin -e -v
> Adding targets...
> Skipping device /dev/blah, is in use...
> 
> 2) Configure the device once again, with --force:
> # tgt-admin --update iqn.2008-08.com.example:some.target --force

Why we can't do `tgt-admin -e -v --force` when we know we will use a
device in use?
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html