[stgt] [PATCH 1/2] tgt-admin: check if direct-device exists before allocating it

[Tomasz Chmielewski]

Tomasz Chmielewski schrieb:
> FUJITA Tomonori schrieb:
>> On Thu, 11 Sep 2008 17:20:08 +0200
>> Tomasz Chmielewski <mangoo at wpkg.org> wrote:
>>
>>> FUJITA Tomonori schrieb:
>>>> On Thu, 11 Sep 2008 16:25:40 +0200
>>>> Tomasz Chmielewski <mangoo at wpkg.org> wrote:
>>>>
>>>>> - allow setting write caching per lun,
>>>>> - allow setting scsi_id, scsi_sn, product_id etc. other parameters, 
>>>>> per lun - useful if one uses multipathd, but not only
>>>> Thanks, looks useful for me.
>>>>
>>>> BTW, I think that we need to improve the default scsi_id and scsi_sn
>>>> values. On IET list, there was discussion about using a hash function.
>>> When was this discussion, and how was the thread titled? I'll look in 
>>> the archives.
>>
>> http://news.gmane.org/group/gmane.linux.iscsi.iscsi-target.devel/last=0/force_load=very/?page=17&action=--Action-- 
>>
>>
>> See threads related with "[patch 0/4] move scsiid/scsisn to volume
>> change gen_scsiid to md5 hash"
>>
>> Note that I don't believe we can provide perfect SCSI ID though I
>> think that we can do better than now.
> 
> Interesting.
> I wonder what other (i.e., non-Linux) target implementations are doing 
> with respect to scsi_id, scsi_sn etc.?

BTW, we may as well generate it in tgt-admin. This could be flexible, as 
multiple schemes could be use.

Default, we would use current behaviour. Or, generate a hash.

Then, we could allow additional schemes, like:

id-naming-scheme last-12-letters
id-naming-scheme hash
id-naming-scheme some-other-scheme-if-someone-submits-a-patch
id-naming-scheme custom /usr/local/sbin/generate_ids_for_tgt-admin


This would have an additional benefit that no changes are needed to tgt 
core code; and new schemes could be easily added by the end user.


-- 
Tomasz Chmielewski
http://wpkg.org
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html