[stgt] [PATCH 2/2] tgt-admin: check if device is mounted on /

[Tomasz Chmielewski]

FUJITA Tomonori schrieb:
> On Fri, 12 Sep 2008 10:19:58 +0200
> Tomasz Chmielewski <mangoo at wpkg.org> wrote:
> 
>> FUJITA Tomonori schrieb:
>>
>> (...)
>>
>>>>> Thanks, sounds good. Any objection against this patch?
>>>> I'm still not persuaded that it's the right approach.
>>>>
>>>> I.e., let's say we have a device which is always in use, but we want 
>>>> tgtd to use it.
>>>>
>>>> With current approach, we have to start tgt-admin several times:
>>>>
>>>> 1) Lets start all targets:
>>>>
>>>> # tgt-admin -e -v
>>>> Adding targets...
>>>> Skipping device /dev/blah, is in use...
>>>>
>>>> 2) Configure the device once again, with --force:
>>>> # tgt-admin --update iqn.2008-08.com.example:some.target --force
>>> Why we can't do `tgt-admin -e -v --force` when we know we will use a
>>> device in use?
>> Because then we can forcibly remove/update targets in use, skip errors etc.
> 
> Hmm, but your scenario is 'lets start all targets'? There is no
> targets in use?

Yeah, if we start from scratch - no problems there.

We can add the config option later, it's just a couple of additional 
lines of code.


-- 
Tomasz Chmielewski
http://wpkg.org
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html