[stgt] [PATCH] fix leak of shared memory
fujita.tomonori at lab.ntt.co.jp
Mon Sep 29 09:52:31 CEST 2008
On Mon, 29 Sep 2008 09:44:15 +0300
Doron Shoham <dorons at Voltaire.COM> wrote:
> >>> You should use the following command:
> >>> tgtadm --op delete --mode system
> >> I wasn't aware of this option.
> >> I couldn't find any info about "--mode system".
> >> It's not written in tgtadm help nor in any man/readme file.
> > We have lots of undocumented features (they are mentioned only on the
> > mailing list). Documents are always welcome.
> >> Anyway, using this command doesn't solve the memory leakage.
> > Yeah, I know. I didn't say that 'tgtadm --op delete --mode system'
> > removes the shared memory.
> Ok, this patch will solve this issue as well.
> > tgtd creates shared memory at startup and exits without cleaning up
> > it. So unless you start and stop tgtd again and again, the leak is not
> > an issue at all.
> That's right, but we still want to solve this problem.
> I have combined my patch and yours (if you don't mind) and update it for
> the current git.
I don't see why your patch still is necessary. My patch solves the
shared memory leak problem. I've applied it.
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the stgt