[stgt] [PATCH 13/14] tgt: bsd_include/ headers, emulates some Linuxism in BSD

[FUJITA Tomonori]

On Thu, 26 Feb 2009 17:03:15 +0200
Boaz Harrosh <bharrosh at panasas.com> wrote:

> FUJITA Tomonori wrote:
> > On Thu, 26 Feb 2009 14:01:34 +0200
> > Boaz Harrosh <bharrosh at panasas.com> wrote:
> > 
> >> FUJITA Tomonori wrote:
> >>> On Wed, 25 Feb 2009 18:08:55 +0200
> >>> Boaz Harrosh <bharrosh at panasas.com> wrote:
> >>>
> >>>> Boaz Harrosh wrote:
> >>>>> FUJITA Tomonori wrote:
> >>>>>> I prefer include/bsd/
> >>>>> Sure, what ever is best for you
> >>>>> Boaz
> >>>>>
> >>>> I just realized, Are you sure you want include/bsd/. This means that include/ is an empty (new)
> >>>> directory with only one subdir in it?
> >>> Yeah, it doesn't look good.
> >>>
> >>> How about just creating a new dir, bsd, and then puting everything in
> >>> it? We will have
> >>>
> >>> usr/bsd/byteswap.h
> >>> usr/bsd/endian.h
> >>> usr/bsd/linux/fs.h
> >>> usr/bsd/epoll.c
> >>> ...
> >>>
> >>> We don't have a directory 'include' for header files now so it's wired
> >>> to create 'include' dir for portability stuff.
> >> This could work, only that I also use all these headers from out-side, from
> >> all of the osd projects (target initiator util) maybe just tgt/bsd strait.
> >>
> >> But I have no strong feelings what ever is best for you I will use.
> >> tgt/bsd or tgt/usr/bsd or tgt/include/bsd it's really the same, what
> >> ever you decide I'll go head and put them in tgt/usr/bsd.
> > 
> > Ok. And then I cancel libos/linux.c and libos/bsg.c stuff:
> > 
> > http://lists.wpkg.org/pipermail/stgt/2009-February/002712.html
> > 
> > 
> > Let's create something like usr/linux/net.c and usr/bsd/net.c
> 
> OK 
> 
> I did not use "libos.h" name I used "os.h" (I search, there is no such file
> in /usr/include of any systems I could search on). I don't like the libos.h
> name since it's usual for when using an external (-devel like) library. But
> I don't have intention to make this a library. It's more a set of headers
> really.

os.h fine by me.

BTW, please include the diffstat in the 0/X patch next time.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html