[stgt] [PATCH] 1/1 Buffer too small to hold date.

[FUJITA Tomonori]

On Thu, 02 Jul 2009 05:24:50 +1000
Mark Harvey <markh794 at gmail.com> wrote:

> FUJITA Tomonori wrote:
> > On Thu, 25 Jun 2009 20:03:03 +1000
> > Mark Harvey <markh794 at gmail.com> wrote:
> >
> >   
> >> Unfortunately, this will make the media incompatible as this changes the MAM struct size.
> >>
> >>
> >> From aca48152858f7d345d07388b82cf232b7d7d6086 Mon Sep 17 00:00:00 2001
> >> From: Mark Harvey <markh794 at gmail.com>
> >> Date: Mon, 22 Jun 2009 16:12:07 +1000
> >> Subject: Need 10 byte array to hold number of secs.
> >>
> >> Signed-off-by: Mark Harvey <markh794 at gmail.com>
> >> ---
> >>  usr/ssc.h |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/usr/ssc.h b/usr/ssc.h
> >> index b72f2bc..4451c2a 100644
> >> --- a/usr/ssc.h
> >> +++ b/usr/ssc.h
> >> @@ -43,7 +43,7 @@ struct MAM_info {
> >>  	uint32_t medium_width;
> >>  	uint8_t assigning_organization_2[8];
> >>  	uint8_t medium_density_code;
> >> -	uint8_t medium_manufacture_date[8];
> >> +	uint8_t medium_manufacture_date[10];
> >>     
> >
> > What does the medium_manufacture_date field store?
> >
> >   
> Nothing of importance.
> The date when the media was created. This is also "duplicated" in the 
> media serial number which has a format of "barcode_<ctime>"
> 
> Feel free to drop if media in-compatability is felt to be more important.

I see, thanks.

Then let's drop it for now. I think that it's better to change the
format only when we really need to do so (we also update the
tape_fmt_version field).

BTW, why 64bits is not large enough to store the date?
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html