[stgt] [PATCH 02/15] tgt: usr/Makefile: Remove none existent include directories

[FUJITA Tomonori]

On Sun,  1 Mar 2009 18:47:32 +0200
Boaz Harrosh <bharrosh at panasas.com> wrote:

> "../include" does not exist in git-tree. It was perhaps added
> so a manual copy of missing Kernel headers for out-of-distro modules
> could be manually copied to ../include/ directory, without need to
> change Makefile. This should not be done, because it is an half baked
> solution. If iser/ib, fc, fcoe, or kernel transport might want
> out-of-tree includes they can do it as:
>     ifneq ($(FOO),)
>     CFLAGS += -DFOO_STUFF
>     INCLUDES += FOO_INCLUDES
>     endif
> 
> Then user can do: make FOO_INCLUDES=../path_to_foo -C usr/tgt.
> The headers are then picked up without a copy, and dependencies also
> work properly. Note that currently none of this is needed if the proper
> dependencies are met according to documentation for example:
> 	$ yum install librdmacm-devel libibverbs-devel
> 
> -I$(KERNELSRC)/include was perhaps used to fetch
> ../include/scsi/scsi_tgt_if.h. (Without changing Makefile). This is
> wrong either include/scsi/scsi_tgt_if.h is exported together with the
> Kernel headers, or it is included in the tgt git-tree at ../include,
> and added to Makefile at that time.
> 
> Signed-off-by: Boaz Harrosh <bharrosh at panasas.com>
> CC: Pete Wyckoff <pw at padd.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html