[stgt] [osd-dev] [PATCH 10/15 ver2] tgt: os.h: getnameinfo() is different on none-Linux systems

Boaz Harrosh bharrosh at panasas.com
Thu Mar 19 07:41:20 CET 2009


FUJITA Tomonori wrote:
> On Thu, 12 Mar 2009 13:17:09 +0200
> Boaz Harrosh <bharrosh at panasas.com> wrote:
> 
>> FUJITA Tomonori wrote:
>>> Your logic is completely crazy to me. I will not merge your work if
>>> you don't change your way.
>>>
>> This is your prerogative, in which case I will have to make my decisions.
>>
>>>> But there's never been a problem. This code works for years just fine.
>>>> The problem at hand is BSD compatibility. As I said changes should be
>>>> separate, cleanups is one thing, BSD code another. Most of the patches
>>>> are BSD only stuff why can't they go in, they do nothing to the code.
>>> The logic is broken. Working code doesn't mean that we don't need to
>>> improve it.
>>>
>> I never said that, I was talking about how to improve it, you answer to
>> things I never said, perhaps you misunderstood.
> 
> Huh?
> 
> What you said is: adding the compatibility code first and then working
> on it (might remove some of them, etc).
> 
> I will not add any crazy compatibility code, which can be removed in
> the future.

I hope there is none left. Do you see something else I should fix?

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list