[stgt] [PATCH] Get "make tarball" working on legacy platforms

[FUJITA Tomonori]

On Tue, 06 Oct 2009 13:58:12 +0200
Florian Haas <florian.haas at linbit.com> wrote:

> On 2009-10-06 13:54, FUJITA Tomonori wrote:
> > I'm not sure if `make tarball` is useful. I don't use it so it's not
> > my problem but I don't want to support something that doesn't work
> > well.
> > 
> > For example, `make tarball` creates useless tarball for me:
> > 
> > fujita at viola:~/git/tgt$ tar tjf tgt-0.9.9.tar.bz2 |head
> > tgt-0.9.9/GPATH
> > tgt-0.9.9/GRTAGS
> > tgt-0.9.9/GSYMS
> > tgt-0.9.9/GTAGS
> > tgt-0.9.9/Makefile
> > tgt-0.9.9/README
> > tgt-0.9.9/conf/
> > tgt-0.9.9/conf/targets.conf
> 
> Well it turns out that the patch actually fixes that too. It will only
> roll Makefile, README, conf/, doc/, scripts/ and usr/ into the tarball.
> 
> > Everyone has other files for other reasons. I don't think that `make
> > tarball` is a good idea.
> 
> See above.

The patch creates another problem; if you add a new file, you need to
change Makefile. Why do I need to do that even if 'make tarball' is
useless for me?


> > You complained that git-archive handles only files in a git tree but
> > it should not be a problem. You have your own git tree so git-archive
> > should create a nice tarball for you.
> 
> But it doesn't work for rolling a tarball that I can then build with
> rpmbuild -tb, which was the whole point.

As a debian packaging tool has, you need to have 'creating a tarball'
feature in your packaging tool.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html