[stgt] Strange sendtargets behaviour

[Chris Webb]

Hi. Sorry for my slow reply.

FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp> writes:

> I can reproduce this problem and I think that I found the root
> cause. It's not about overrun buffer but tgtd sends a wrong buffer to
> initiators.
> 
> When text_key_add() realloc conn->rsp_buffer for a long text response,
> we need to set conn->rsp.data again (otherwise conn->rsp.data points
> to a wrong memory including garbage and sends it later).

Ah yes, I see the problem; this would explain it very well.

> I'll add multiple text PDU support later but can you test this minimum
> fix?

This fix appears to work perfectly: I can no longer reproduce the
corruption with my test script. Many thanks!

Best wishes,

Chris.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html