[stgt] [PATCH 1/1] enhance tgtimg to create media for DVD emulation

[FUJITA Tomonori]

On Fri, 2 Apr 2010 18:06:48 +1100
ronnie sahlberg <ronniesahlberg at gmail.com> wrote:

> This patch is a trivial patch that just makes tgtimg create an empty
> file to be used for dvd+r burnable media.
> This can most definitely be done just as well with "touch file", but
> doing it with tgtimg offers two small benefits
> 1, using the same command to create MMC devices as SSC devices,
> eventhough the command is a trivial reimplementation of "touch"
> 2, allows a natural place in the manpages to describe how to create
> MMC device image files.
> 
> While trivial, 2 I think is a strong benefit. It makes it easier for
> the user browsing manpages to find out how to create a image file for
> MMC
> instead of looking into /usr/share/doc/tgt/README.mmc
> 
> Similarly to add a later patch to use tgtimg to create a DISK image.
> Which would really just be a reimplementation of dd if=/dev/zero
> of=<file)
> but more userfriendly and documented in the tgtimg manpage.
> 
> 
> What drives me here is my opinion : "if its not in the manpage, it
> doesnt exist".
> 
> 
> 
> So I wont add any xattr or other metadata changes to tgtimg, but would
> these trivial changes to tgtimg to create, and document,.mmc and sbc
> image files be acceptable?

Ok, I've just merged the patch.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html