[stgt] PATCH: support shared accounts in targets.conf

[FUJITA Tomonori]

On Wed, 28 Apr 2010 13:46:28 -0600
Dax Kelson <dkelson at gurulabs.com> wrote:

> I tried creating a targets.conf with multiple targets, all with the same
> outgoing account. 
> 
> Snippet from my targets.conf:
> 
> <target iqn.1999-07.com.gurulabs:station1>
>         backing-store /srv/iscsi-luns/station1
>         incominguser station1 letmein
>         outgoinguser server1 itsreallyme
> </target>
> 
> <target iqn.1999-07.com.gurulabs:station2>
>         backing-store /srv/iscsi-luns/station2
>         incominguser station2 letmein
>         outgoinguser server1 itsreallyme
> </target>
> 
> <target iqn.1999-07.com.gurulabs:station3>
>         backing-store /srv/iscsi-luns/station3
>         incominguser station3 letmein
>         outgoinguser server1 itsreallyme
> </target>
> 
> The current logic in tgt-admin doesn't having the same account (incoming
> or outgoing) defined on multiple targets. The current logic always
> deletes an account before adding which removes the account from any
> already defined targets.
> 
> Attached is a tested patch to support the configuration above:

You mean that with this patch tgt-admin adds the existing account to
targets without the removing? If so, I'm happy to merge it.

Can I add your Signed-off-by to the patch? If you haven't heard about
"Signed-off-by", please see Chapter 3

http://www.kernel.org/doc/Documentation/SubmittingPatches

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html