[stgt] Have some questions w.r.t iSNS implementation in stgt

[FUJITA Tomonori]

On Fri, 30 Jul 2010 19:33:07 -0700
Chandra Seetharaman <sekharan at us.ibm.com> wrote:

> 1. What is the purpose of isns_timeout_fn() ? We send a
> isns_attr_query() to the iSNS server (every 30 second) on the last
> defined target and just dump the server's response on the floor. Why do
> it ?

I can't recall much about it. But I guess if we don't do scn, we need
to update the info (such as the list of initiators) periodically?


> 2. isns_connect() is called from multiple places. Why can't we call it
> at the init time once and remove the redundant calling of it at multiple
> places.

A connection with an iSNS server might be closed. We need to
reconnect in such case, I think.


> 3. iSNS has to be turned on before any targets are defined. If I turn on
> iSNS after defining the target, if I turn on iSNS the targets that are
> already defined are not registered with the server. Is it intentional,

Because I'm lazy.

> are there any problems in registering all the defined targets ?

No. A patch is welcome.


> 4. Code prevents iSNS from being turned Off once turned On. Why ?

Again because I'm lazy. :)


> 5. Why a isns_attr_query(target_name) is made to the server after a
> target is registered (isns_target_register()).

I thought that the spec needs it but I'm not sure. Or MS isns server
might require it. I can't recall.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html