[stgt] [PATCH 1/1] Add a manpage for TGTD in XSLT format and makefile changes to build it.

[FUJITA Tomonori]

On Wed, 17 Feb 2010 11:16:43 +1100
ronnie sahlberg <ronniesahlberg at gmail.com> wrote:

> Please find attached a small patch that adds initial documentation in
> XSLT format for tgtd.
> 
> This file is, if xsltproc is present, used to generate both a manpage
> and a html page for tgtd.

Great, thanks a lot!

I have some comments (I might be totally wrong since I don't know
xsltproc stuff).


> Signed-off-by: Ronnie Sahlberg <ronniesahlberg at gmail.com>
> ---
>  doc/Makefile              |   17 ++++++-
>  doc/htmlpages/tgtd.8.html |   40 +++++++++++++++
>  doc/manpages/tgtd.8       |   81 +++++++++++++++++++++++++++++

Do we need to add tgtd.8.html and tgtd.8? I thought that xsltproc
generates them from tgtd.8.xml?


>  doc/tgtd.8.xml            |  123 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 260 insertions(+), 1 deletions(-)
>  create mode 100644 doc/htmlpages/tgtd.8.html
>  create mode 100644 doc/manpages/tgtd.8
>  create mode 100644 doc/tgtd.8.xml
> 
> diff --git a/doc/Makefile b/doc/Makefile
> index f7cdfd3..77b6f87 100644
> --- a/doc/Makefile
> +++ b/doc/Makefile
> @@ -2,10 +2,15 @@ mandir ?= $(PREFIX)/share/man
>  docdir ?= $(PREFIX)/share/doc/tgt
>  
>  MANPAGES = manpages/tgtadm.8 manpages/tgt-admin.8 \
> -		manpages/tgt-setup-lun.8
> +		manpages/tgt-setup-lun.8 manpages/tgtd.8
> +
>  DOCS = README.fcoe README.ibmvstgt README.iscsi README.iser \
>  	    README.lu_configuration README.mmc tmf.txt
>  
> +XSLTPROC = /usr/bin/xsltproc
> +XMLMAN = manpages/tgtd.8
> +XMLHTML = htmlpages/tgtd.8.html
> +
>  .PHONY:all
>  all:
>  
> @@ -19,3 +24,13 @@ install: $(MANPAGES) $(DOCS)
>  .PHONY: clean
>  clean:
>  
> +manpages/tgtd.8: tgtd.8.xml
> +	-test -z "$(XSLTPROC)" || $(XSLTPROC) -o $@ http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl $<
> +
> +htmlpages/tgtd.8.html: tgtd.8.xml
> +	-test -z "$(XSLTPROC)" || $(XSLTPROC) -o $@ http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl $<

It means that it tries to connect to docbook.sf.net? If so, can we use
the local files instead?

fujita at rose:~/git/tgt/doc$ xsltproc /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl tgtd.8.xml
Note: meta date   : no date; using generated date                  tgtd
Note: meta date   : see http://docbook.sf.net/el/date              tgtd
Note: meta source : no *info/productname or alternative            tgtd
Note: meta source : see http://docbook.sf.net/el/productname       tgtd
Note: meta source : no refentry/refmeta/refmiscinfo at class=source   tgtd
Note: meta source : see http://docbook.sf.net/el/refmiscinfo       tgtd
Note: meta version: no *info/productnumber or alternative          tgtd
Note: meta version: see http://docbook.sf.net/el/productnumber     tgtd
Note: meta version: no refentry/refmeta/refmiscinfo at class=version  tgtd
Note: meta version: see http://docbook.sf.net/el/refmiscinfo       tgtd
Warn: meta source : no valid fallback for source; leaving empty    tgtd
Note: meta manual : no titled ancestor of refentry                 tgtd
Note: meta manual : no refentry/refmeta/refmiscinfo at class=manual   tgtd
Note: meta manual : see http://docbook.sf.net/el/refmiscinfo       tgtd
Warn: meta manual : no valid fallback for manual; leaving empty    tgtd
Note: Writing tgtd.8
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html