[stgt] [PATCH] changes in iscsi login/text prototypes, structs

[FUJITA Tomonori]

On Fri, 24 Sep 2010 13:03:20 +0200
"Alexander Nezhinsky" <alexandern at voltaire.com> wrote:

> >> If you are afraid of breaking iscsi/tcp by applying the patch directly 
> >> to "master", perhaps another approach will work. You can start a new branch,
> >> from the "master", apply the last patch there, and i'll start sending patches
> >> destined for the new branch. 
> >> I'll resend the new iser code, w/out duplicated login, then add a patch
> >> for bidi support and a few other small fixes i've made recently to iser.
> 
> > Distributions will not ship a new branch. When the new iser
> > code (with bidi support) is ready, I'll merge it at a time.
> 
> I did not meant the distributions at all. What is the process for making 
> large or structural changes? I can work out it all by myself, making changes
> in the whole way iscsi code works and be happy with it. You will be probably
> less happy, and reluctant to even try such a thing. If i go small step at a
> time, then each time merging will pose a risk of breaking a release.
> So i propose opening a branch (say from 1.0.8), and merging the patches there 
> after they are reviewed. We can ask all those guys who experienced data loss
> with iser to try the branch once it has the minimal new code in it. 

I'm not sure that these guys can test it in such timely manner.


> Then when it is tested, and has all the lacking features, we merge it, 
> and only then the distros enter the game.

Please send the iser full-feature patchset that makes the minmum
changes to the core iSCSI. I don't care about how much the duplication
is. After merging it, you can work on removing the duplication step by
step.


Thanks,

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html