[stgt] [PATCH 0/1] iSCSI statistics for stgt.

[Daniel Henrique Debonzi]

FUJITA Tomonori wrote:
> On Mon,  4 Oct 2010 14:08:45 -0300
> Daniel Henrique Debonzi <debonzi at linux.vnet.ibm.com> wrote:
> 
>> This patch adds the possibility to check some iscsi statistics on the stgt.
> 
> Sounds a good feature.
> 
> iscsi_stats has enough information? open-iscsi also supports the
> iscsi status, I think. iscsi_stats has the similar info?

I think it is for the moment but we can always add more if needed on
future. It is exactly the same structure we have on open-iscsi.

>> I have in mind that it may impact the performance as it is now and there
>> should be a way to enable/disable it or even compile with stats support or not.
> 
> I think that we are ok without the compile option. Enabling/disabling
> the feature per target sounds reasonable?

Sounds good to me.

> 
> 
> Hmm, this can't be applied cleanly to the latest git:
> 

I will send a new patch based on the last tgt commit.
Regards,
Daniel Debonzi

> 
> fujita at rose:~/git/tgt$ patch -p1 < /home/fujita/Mail/inbox/154
> patching file usr/iscsi/iscsid.h
> patching file usr/tgtadm.h
> patching file usr/iscsi/iscsid.c
> Hunk #1 succeeded at 1917 (offset -1 lines).
> Hunk #2 succeeded at 1943 (offset -1 lines).
> Hunk #3 succeeded at 2098 (offset -1 lines).
> patching file usr/iscsi/target.c
> Hunk #1 succeeded at 532 (offset 79 lines).
> Hunk #2 succeeded at 653 (offset 79 lines).
> patching file usr/tgtadm.c
> Hunk #1 FAILED at 383.
> 1 out of 1 hunk FAILED -- saving rejects to file usr/tgtadm.c.rej
> 
> I also got compile warnings:
> 
> iscsi/target.c: In function ‘iscsi_target_show_stats’:
> iscsi/target.c:598: warning: format ‘%lld’ expects type ‘long long int’, but argument 4 has type ‘uint64_t’
> iscsi/target.c:598: warning: format ‘%lld’ expects type ‘long long int’, but argument 5 has type ‘uint64_t’
> iscsi/target.c:598: warning: format ‘%lld’ expects type ‘long long int’, but argument 4 has type ‘uint64_t’
> iscsi/target.c:598: warning: format ‘%lld’ expects type ‘long long int’, but argument 5 has type ‘uint64_t’
> 
> 
> Thanks,

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html