[stgt] [PATCH 1/1] iscsi: Initial iscsi statistics for stgt.

[FUJITA Tomonori]

On Wed,  6 Oct 2010 11:18:05 -0300
Daniel Henrique Debonzi <debonzi at linux.vnet.ibm.com> wrote:

> From: Daniel Henrique Debonzi <debonzi at linux.vnet.ibm.com>
> 
> This patch implements some statistics information for the iscsi.
> 
> Signed-off-by: Daniel Henrique Debonzi <debonzi at linux.vnet.ibm.com>
> ---
>  usr/iscsi/iscsid.c |   26 +++++++++++++++++
>  usr/iscsi/iscsid.h |    2 +
>  usr/iscsi/target.c |   78 +++++++++++++++++++++++++++++++++++++++++++--------
>  usr/tgtadm.c       |    2 +
>  usr/tgtadm.h       |    1 +
>  5 files changed, 96 insertions(+), 13 deletions(-)

Can you fix write space errors?

fujita at rose:~/git/tgt$ git am -i ~/Mail/kernel/stgt/2496
Commit Body is:
--------------------------
iscsi: Initial iscsi statistics for stgt.

This patch implements some statistics information for the iscsi.

Signed-off-by: Daniel Henrique Debonzi <debonzi at linux.vnet.ibm.com>
--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: iscsi: Initial iscsi statistics for stgt.
/home/fujita/git/tgt/.git/rebase-apply/patch:89: trailing whitespace.
static struct iscsi_session *iscsi_target_find_session(struct
iscsi_target* target,
/home/fujita/git/tgt/.git/rebase-apply/patch:117: trailing whitespace.

/home/fujita/git/tgt/.git/rebase-apply/patch:119: trailing whitespace.

/home/fujita/git/tgt/.git/rebase-apply/patch:142: trailing whitespace.
                        len = snprintf(buf, rest,
/home/fujita/git/tgt/.git/rebase-apply/patch:158: trailing whitespace.

warning: 5 lines add whitespace errors.

I also got compile warnings:

iscsi/target.c: In function ‘iscsi_target_show_stats’:
iscsi/target.c:598: warning: format ‘%lld’ expects type ‘long long
int’, but argument 4 has type ‘uint64_t’
iscsi/target.c:598: warning: format ‘%lld’ expects type ‘long long
int’, but argument 5 has type ‘uint64_t’
iscsi/target.c:598: warning: format ‘%lld’ expects type ‘long long
int’, but argument 4 has type ‘uint64_t’
iscsi/target.c:598: warning: format ‘%lld’ expects type ‘long long
int’, but argument 5 has type ‘uint64_t’
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html