[stgt] [PATCH v3] redirect: protect again tgtd process hang as of cluster software hang

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Tue Mar 22 11:18:29 CET 2011


On Tue, 22 Mar 2011 08:44:10 +0200
Or Gerlitz <ogerlitz at mellanox.com> wrote:

> If the child process spawned to run the redirect callback script hangs, e.g
> as of load/bug in the application which this script is dealing with, tgt
> can hang forever. Protect against that by selecting the fd from which tgt
> is expected to read, for up to 100ms, if the timeout expires, tgt terminates
> the child process and fail the initiator login attempt. While not being the
> ultimate solution, of using tgt_event_add et al. and making the redirect
> code fully asynchronous, this patch adds protection and makes things much
> better in that respect.
> 
> Signed-off-by: Alexander Nezhinsky <alexandern at mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz at mellanox.com>
> 
> -----
> changes from V1:
> 	added a comment and few formatting changes
> 
> changes from V2:
> 	fixed some checkpatch warnings
> 
>  usr/tgtd.c |   29 ++++++++++++++++++++++++-----
>  1 files changed, 24 insertions(+), 5 deletions(-)

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list