[stgt] [PATCH] LBPPBE: when opening the backing file, check the blocksize of the underlying filesystem and set lbppbe automatically.

[FUJITA Tomonori]

On Wed, 18 Apr 2012 21:51:15 +1000
ronnie sahlberg <ronniesahlberg at gmail.com> wrote:

> What we could do is
> 
> When we open the backing store, we always set lbppbe based on the
> blocksize of the backing file.
> Then, if the user wants a different  lbppbe, he/she can set it via tgtadm.
> 
> If the user then makes the lun offline/online   this resets the lbppbe
> back to the blocksize of the backing file
> so the user is then responsible to use tgtadm to reset the lbppbe
> value back to what he/she wants.
> 
> 
> Then document the fact that "once you set lbppbe using tgtadm, this
> only lasts until the LUN is made offline/online. lbppbe are reset
> across a offline/online operation so if you really need a specific
> value you have to reset it with tgtadm after every offline/online
> cycle".

Yeah, but I guess that the most of users would expect that once he
sets it by hand, tgt keeps it until it is removed.

So I applied the patch. I would prefer something like
"user_specified_lbppbe" but the patch is fine by me.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html