[stgt] [PATCH 0/4] style improvement patches for few source files

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Thu Aug 9 22:25:03 CEST 2012


On Thu, 9 Aug 2012 21:27:45 +0300
Alexander Nezhinsky <nezhinsky at gmail.com> wrote:

> On Thu, Aug 9, 2012 at 7:35 PM, FUJITA Tomonori
> <fujita.tomonori at lab.ntt.co.jp> wrote:
> > On Wed,  8 Aug 2012 10:03:20 +0300
> > nezhinsky at gmail.com wrote:
> 
> >> This is a series of patches for a few "main" sources files.
> >> It fixes the style errors and warnings detected by curent version of checkpatch.pl.
> 
> > Sorry, as I said before, I don't like to apply 'pure style fix' patches.
> 
> Tomo,
> 
> It was my understanding that we had agreed upon such 'pure style fix'  :
> 
> >> Let's tolerate those 80 chars transgressions as they are just for now
> >> and fix them all in one blow.
> >> I'm more than ready to produce a "style improvement" patch-set if we
> >> decide that it is due.
> >
> > ok, I've applied and pushed. Thanks.

Ok, I'll apply this time. However, I got the warning after applying
the first:

tgtd.c: In function ‘main’:
tgtd.c:576: warning: passing argument 1 of ‘log_init’ discards
qualifiers from pointer target type
log.h:65: note: expected ‘char *’ but argument is of type ‘conchar *’


Can you recheck?

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list