[stgt] [PATCH 4/4] tgt-admin: Base blocksize & params on backing store if direct-store

[Andy Grover]

On 01/06/2012 01:08 AM, Tomasz Chmielewski wrote:
>>               # These options can be fetched by sg_inq for direct-store
>> -            my @opts = ("vendor_id", "product_id", "product_rev",
>> "scsi_sn");
>> +            my @opts = ("vendor_id", "product_id", "product_rev",
>> "scsi_sn",
>> +                    "lbppbe", "la_lba", "optimal_xfer_gran",
>> "optimal_xfer_len");
>>               foreach my $single_opt (@opts) {
>>                  
>> check_if_hash_array($$target_options_ref{$single_opt},$single_opt);
>>                   my $this_opt;
> 
> Can we have the examples of these new options added to the sample config
> file as well?
> This way, a user can see what's possible to set.

I would argue they're only configurable for testing purposes. I can't
think of any case where a user would want to set these, instead of
letting tgt-admin set them automatically, based on the backing device's
properties.

Also, there is a manpage for targets.conf now (generated from
doc/targets.conf.5.xml) that would be a better place than the sample
config file to be the reference for all available options. I'll document
the new ones I'm adding. Others should feel free to document the
existing options, and maybe even tackle a sample config cleanup someday?

Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html