[stgt] [PATCH RESEND 0/3] Add SCSI cmd statistics per ITL nexus

Alexander Nezhinsky nezhinsky at gmail.com
Wed Jul 18 00:47:51 CEST 2012

On Wed, Jul 18, 2012 at 1:31 AM, ronnie sahlberg
<ronniesahlberg at gmail.com> wrote:
> Hi,
> Since all media access commands take a 5 bit groupnumber for this
> specific purpose
> we should make sure that the stats are collected into 32 different
> buckets depending of the group number in the CDB

It's a good point and we may decide to do so, but it seems to be mandatory
only if presented in "Statistics and Performance" page.
We are presenting it for the target's admin thus it is at least "not a bug"
to do it without the group number bins.

Moreover, collecting cmds to bins should be done *in addition* to the
current scheme,
and not instead of it, because not all commands have group number.
Should the other "non-grouped" cmds be collected to a special bin?

Anyway, let's decide on how we make it fully spec compliant and add this
group flavor the statistics.

To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

More information about the stgt mailing list