[stgt] [PATCH] UNMAP Change order of no-media and thin-provisioning tests
FUJITA Tomonori
fujita.tomonori at lab.ntt.co.jp
Wed Jul 18 00:51:21 CEST 2012
On Wed, 18 Jul 2012 08:39:21 +1000
ronnie sahlberg <ronniesahlberg at gmail.com> wrote:
> From 0185f0a1c27c51add98a9754a24f1ad52ff1db15 Mon Sep 17 00:00:00 2001
> From: Ronnie Sahlberg <ronniesahlberg at gmail.com>
> Date: Wed, 18 Jul 2012 08:32:09 +1000
> Subject: [PATCH] Check for MediaPresent before checking for ThinProvisioning in UNMAP call
>
> This patch does not change any logic, only in which order two error checks
> are performed.
>
> Currently the checks are made in the order
> 1, if not ThinProvision then error
> 2, if NoMedia then error
>
> Since Thin-Provisioning is an attribute of the media itself and not the LUN,
> it makes more sense to check these two properties in the reverse order :
>
> 1, if NoMedia then error
> 2, if not ThinProvisioned then error
>
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg at gmail.com>
> ---
> usr/sbc.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
Sounds make sense. Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the stgt
mailing list