[stgt] [PATCH RESEND 0/3] Add SCSI cmd statistics per ITL nexus
fujita.tomonori at lab.ntt.co.jp
Wed Jul 18 01:03:42 CEST 2012
On Wed, 18 Jul 2012 01:59:35 +0300
Alexander Nezhinsky <nezhinsky at gmail.com> wrote:
> On Wed, Jul 18, 2012 at 1:49 AM, FUJITA Tomonori
> <fujita.tomonori at lab.ntt.co.jp> wrote:
> >> > I got many checkpatch errors on them. Please fix them.
> >> Fixed 2 patches where some glitches unrelated to "line over 80 chars"
> >> were found. A couple of other warnings, if fixed, would disrupt the de-facto style
> >> like no space before bracket in "int (*f)(void)"
> > You can ignore some warnings if fixing these warnings would lead to
> > ugly code.
> > However, I'm not sure why you can't fix something like the following:
> > WARNING: line over 80 characters
> > #250: FILE: usr/iscsi/iser.c:2931:
> > + iscsi_update_conn_stats_rx(&conn->h, rdmad->sge.length, ISCSI_OP_SCSI_DATA_OUT);
> I could fix those warnings.
> My reasoning was that the code is full of lines over 80 chars
> and some if not most of them can be "fixed" without producing ugly code.
> The same goes to all other minor warning types.
> Let's tolerate those 80 chars transgressions as they are just for now
> and fix them all in one blow.
> I'm more than ready to produce a "style improvement" patch-set if we
> decide that it is due.
ok, I've applied and pushed. Thanks.
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the stgt