[stgt] [PATCHv2] fix bugs in persistent group reservations

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Mon Jan 14 12:23:47 CET 2013


On Sun, 23 Dec 2012 11:37:33 -0800
Lee Duncan <lduncan at suse.com> wrote:

> I created a small Persistent Group Reservations test suite, available
> at git://github.com/gonzoleeman/open-iscsi-pgr-validate. It uncovered
> several bugs in the SCSI target's PGR implementation. Here is a list
> of the tests that failed or could not run:
> 
> Reserve Exclusive Access:
>   - Can release reservation:				ERROR
>   - Unregister Releases Reservation:			FAIL
> 
> Reserve Write Exclusive:
>   - Resvn Holder Unregister Releases Resvn:		FAIL
>   - Non-Registrant Does Not Have Read Access:		FAIL
>   - Non-Resvn-Holder Has Read Access:			FAIL
> 
> Reserve Exclusive Access Registrants Only:
>   - Unregister Releases Reservation:			FAIL
> 
> Reserve Write Exclusive Registrants Only:
>   - Resvn Holder Unregister releases resvn:		FAIL
> 
> Reserve Exclusive Access All Registrants:
>   - Alternative Resvn Holder Can Release Resvn:		FAIL
>   - Main Resvn Unregister Does Not Release Resvn:	FAIL
> 
> Reserve Write Exclusive All Registrants:
>   - Alt Resvn Holder Can Release Resvn:			FAIL
>   - Main Resvn Holder Unregister does not
> 	 release resvn:					FAIL
> 
> This patch enables all PGR tests is said suite to pass.
> 
> Changes since v1 of this patch:
>  - Removed refactoring for pr_type all registrant checks
>  - removed previously-added list_is_last() and use thereof
> 
> Signed-off-by: Lee Duncan <lduncan at suse.com>
> --- 
>  usr/spc.c |   73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list