[stgt] [PATCH] bs_rbd: fix error assignment in if condition

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Fri Jul 25 09:31:07 CEST 2014


On Wed, 23 Jul 2014 10:38:34 +0800
Ruoyu <liangry at ucweb.com> wrote:

> The statement
> 
> if ((x == f()) < 0) {}
> 
> is strange. I think it should be
> 
> if ((x = f()) < 0) {}
> 
> For the reasone of coding style, I modify it as
> 
> x = f();
> if (x < 0) {}
> 
> Signed-off-by: Ruoyu <liangry at ucweb.com>
> ---
>  usr/bs_rbd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list