[wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=173


Rainer Meier <r.meier at wpkg.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |r.meier at wpkg.org
         Resolution|                            |FIXED




--- Comment #1 from Rainer Meier <r.meier at wpkg.org>  2009-09-21 19:34:55 ---
Hi Stefan

Sounds like a reasonable request. At the beginning I thought "yes, of course,
let's quickly do it". Unfortunately it became a bit more complex. Especially
this requires on every revision number query to set the full package
environment and restore it after evaluating it.
To prevent this for packages where it is not needed (I think using environment
variables in revision strings will not become very popular) I've added a quick
check and variables will be expanded only if at least two "%" characters are
found.

Here is the change log:

Changes 2009-09-21, v1.1.2-RC18 by Rainer Meier <r.meier (at) wpkg.org>
MOD: Added check for package revision environment expansion. Expansion is only
     done if the revision string contains two "%" characters which indicates
     an environment definition in the form of %VAR%.
     This should prevent unneeded environment setups and therefore it prevents
     wasting resources.

Changes 2009-09-21, v1.1.2-RC17 by Rainer Meier <r.meier (at) wpkg.org>
NEW: Expands environment variables in package revision. For example
     revision="%PRG_VERSION%" is valid now. Make sure the environment variable
     is defined before you use it.
     Fixes Bug 173. Thanks to Stefan Pendl.


Any feedback appreciated.


<http://wpkg.svn.sourceforge.net/viewvc/wpkg/wpkg/stable/1.1/wpkg.js?view=log>

br,
Rainer

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.