[wpkg-users] [Bug 209] Replace variables in package revisions by their value in local wpkg.xml file

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=209

--- Comment #19 from Rainer Meier <r.meier at wpkg.org>  ---
Fix committed:

FIX: Fixed bug that "name" attribute in host node was completely ignored in
     previous commits. Fixes classic host-name matching.


Now all wpkg-test test-cases run successfully on my test environment. However I
had to do some modifications. Mainly hosts.xml of the test4 suite had some host
and IP matching regexp which did not match correctly. In fact I think this was
a bug of the test case, not of WPKG so I've changed it.

<host ipaddresses=".+1" profile-id="allip-1" />
changed to
<host ipaddresses="^.+1$" profile-id="allip-1" />

The above regexp also matches my test node IP (10.0.0.x). The regular
expression would match if the IP has any 1 in it. The updated one will match
only if the IP ends with 1. Maybe this is not the intention of this matching
but I could not imagine that it shall match all IPs (expression "^.+$") -
especially since the expected WPKG result would not include the allip-1 result.
So it would break again. So the expression somehow shall not match the host.

A similar issue was discovered with the expression:
<host name=".+1" profile-id="allname-1" />

In some tests it was expected that this matches all hosts (I guess). But the
regexp ".+1" would not just match everything. Instead it says to match anything
which has a "1" in it after 1 or more initial characters. So it would match the
host "a1", "abc1de", "0123"... but not "1abc".
I've changed it to the expression "^.+$" which simply matches any host name
which is not empty.

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.