[wpkg-users] [Bug 277] New: createSettings can cause crash if not all values could be detected

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=277

           Summary: createSettings can cause crash if not all values could
                    be detected
           Product: WPKG
           Version: other
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: wpkg.js
        AssignedTo: mangoo at wpkg.org
        ReportedBy: john.spackman at zenesis.com
         QAContact: wpkg-users at lists.wpkg.org


On line 2033 of wpkg.js (v1.3.0) attributes are copied into newSettings
regardless of whether they are null or null - but null values cause the script
to crash saying this:

    Message:      Type mismatch
    Description:  Type mismatch
    Error number: 800a000d
    Stack:        undefined
    Line:         undefined

We have several Windows XP Embedded boxes on which some of the detection
routines in wpkg fail - for example, we get these messages:

  Error when searching registry sub-keys at 'HKLM\SOFTWARE\Microsoft\Windows
NT\CurrentVersion\NetworkCards\'
  Code: 800a01ad; Descriptions: Automation server can't create object
  Message: Unable to get domain information.
  Message: Unable to get domain information.
  Message: Unable to fetch computer membership groups. Probably not a domain
member.

The errors all seem to have no lasting effect except that createSettings later
crashes.  The fix is easy:

function createSettings() {
    var newSettings = createXml("wpkg:wpkg", namespaceSettings);
    if (settingsHostInfo) {
        // Add host attributes.
        // NOTE: These attributes are currently not used by WPKG but might be
        // useful if wpkg.xml is copied to an external system so wpkg.xml
        // will include some host information.
        var hostInformation = getHostInformation();
        var attributes = hostInformation.keys().toArray();
        for (var i=0; i<attributes.length; i++) {
            var value = hostInformation.Item(attributes[i]);
            if (value) {
                newSettings.setAttribute(attributes[i], value);
            }
        }
    }
    return newSettings;
}

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.