[Sheepdog] [PATCH v4 6/7] sheep: change hdr flags uint32_t from uint16_t

[Liu Yuan]

On 10/19/2011 12:37 PM, MORITA Kazutaka wrote:

>>>
>>> I don't want to change network protocols easily.  This forces us to
>>> change client codes in QEMU too, and users suffer from the
>>> compatibility problem.
>>>
>>> Isn't it much better to make all flags uint16_t?
>>>
>>
>>
>> get/set_cluster_flags() use uint32_t and I think 16 flags would be
>> limited for future dev. And more, we'd better leave at least one extra
>> pad that is unused right now but would be ready for future use.
>>
>> If we don't change it now, I guess, in the later future, we are likely
>> to face it again and a greater suffering to change this ABI.
> 
> Let's change it when we really need it.  I think we can live with 16
> bit flags.
> 


Okay, I'll prepare the patch to get/set cluster flags uint16_t along
with the halt patch.

Thanks,
Yuan