[Sheepdog] [PATCH 3/3] sheep: add set/get_cluster_status()

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Oct 18 09:22:19 CEST 2011


At Tue, 18 Oct 2011 14:51:07 +0800,
Liu Yuan wrote:
> 
> On 10/17/2011 10:05 PM, MORITA Kazutaka wrote:
> 
> > This patch is preparation for adding SD_STATUS_HALT support.
> > 
> > Signed-off-by: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp>
> > ---
> >  sheep/sheep_priv.h |    2 ++
> >  sheep/store.c      |   37 +++++++++++++++++++++++++++++++++++++
> >  2 files changed, 39 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sheep/sheep_priv.h b/sheep/sheep_priv.h
> > index cccb986..a7d5c25 100644
> > --- a/sheep/sheep_priv.h
> > +++ b/sheep/sheep_priv.h
> > @@ -210,6 +210,8 @@ int update_epoch_store(uint32_t epoch);
> >  
> >  int set_global_nr_copies(uint32_t copies);
> >  int get_global_nr_copies(uint32_t *copies);
> > +int set_cluster_flags(uint32_t flags);
> > +int get_cluster_flags(uint32_t *flags);
> >  
> 
> 
> How about changing set/get_global_nr_copies() into
> set/get_cluster_copies() in passing?

Looks good to me, but it should be done in another patch.  I'll send
the patch after reviewing and merging your SD_STATUS_HALT patchset.


Thanks,

Kazutaka



More information about the sheepdog mailing list