[Sheepdog] [PATCH v3] logger: correct crash_handler output

Liu Yuan namei.unix at gmail.com
Sun Apr 29 15:18:11 CEST 2012


On 04/29/2012 06:38 PM, Christoph Hellwig wrote:

> Eww, this is too ugly for words.  Please make "pid" a private variable
> inside the block it's used, and add a global sheep_pid variable to hold
> the pid for the sheep process.
> 


Errr, it is not me to use pid as a global name. I just fixes the
regression that happen to be brought in by your patch. Nevertheless, I'd
like to use sheep_pid as a global name. I'll patch up a V4 for it.

Thanks,
Yuan



More information about the sheepdog mailing list