[sheepdog] [PATCH] new option -i to initialize storage directory

Dietmar Maurer dietmar at proxmox.com
Fri Jul 20 10:59:14 CEST 2012


> If you're going to do this, might it be better to test for the existence of the
> typical obj, journal, epoch directories rather than mandate the existence of a
> magic file with a long name and an ugly underscore?

That file should be a 'unique marker'. I can't see why it is 'magic' or 'ugly' (why is an underscore ugly?)

> However, it still feels like you should just be doing
> 
>   [ -d /store/journal ] && sheep /store
> 
> in your init scripts rather 

Those files depends on the used storage backend, so you can't use them.

Also, I want to start 'sheep' without using /etc/init.d/ script, so checks there are quite useless.

- Dietmar




More information about the sheepdog mailing list