On 06/02/2012 10:12 PM, Christoph Hellwig wrote: > On Sat, Jun 02, 2012 at 08:52:39PM +0800, Liu Yuan wrote: >> From: Liu Yuan <tailai.ly at taobao.com> >> >> v2: >> - Apply this to sheep binary too >> -------------------------------------- >8 >> >> As a side effect, the coredump file will be located /path/to/store dir >> instead of previous '/'. We also don't overlap core file when multiple sheeps >> run on the same machine. > > The change looks fine to be, but if you want even better corefile > placement look at the kernel.core_pattern sysctl. I have it set to > > /corefiles/core.%e.%p.%h.%t > > which gives you all corefiles in /corefiles with a very descriptive > name. (you want /corefiles read/write/executable by the world and sticky > for it, just like /tmp) > Thanks for your tips, this sysctl doesn't conflict with the default core-dump location, which this patch tries to place it to per-store directory, giving a good namespace for it too. Thanks, Yuan |