On 06/25/2012 07:02 PM, Christoph Hellwig wrote: > Is there any good reason to use networking to talk to the local node > instead of directly queueing it up on the workqueue? > > Also is there any good reason to not treat write and remove requests > the same way? If there is a good reason to do that it should probably > be added to the code as a comment to explain the asymetric > implementation. His new version of the patch set does the direct queuing as I suggested. But probably Levin should prefix the new version with [PATCH v2] to make it obvious. http://lists.wpkg.org/pipermail/sheepdog/2012-June/004740.html Thanks, Yuan |