[sheepdog] [PATCH] sheep: remove SD_OP_SHEEP

Christoph Hellwig hch at infradead.org
Tue Jun 26 12:25:36 CEST 2012


Remove the unused placeholder and replace it with a comment explaining
what the deal with 0x80 or higher opcode is.

Signed-off-by: Christoph Hellwig <hch at lst.de>

---
 include/sheep.h |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Index: sheepdog/include/sheep.h
===================================================================
--- sheepdog.orig/include/sheep.h	2012-06-26 12:07:10.143315358 +0200
+++ sheepdog/include/sheep.h	2012-06-26 12:10:50.916647373 +0200
@@ -28,7 +28,11 @@
 #define SD_MAX_VNODES 65536
 #define SD_MAX_VMS   4096 /* FIXME: should be removed */
 
-#define SD_OP_SHEEP          0x80
+/*
+ * Operations with opcodes above 0x80 are considered part of the inter-sheep
+ * protocol and will in the near future be versioned independently of the
+ * external sheepdog protocol.
+ */
 #define SD_OP_DEL_VDI        0x81
 #define SD_OP_GET_NODE_LIST  0x82
 #define SD_OP_GET_VM_LIST    0x83
@@ -268,11 +272,6 @@ static inline void obj_to_sheeps(struct
 				(pos + 1) % nr_entries, idx);
 }
 
-static inline int is_sheep_op(uint8_t op)
-{
-	return op & SD_OP_SHEEP;
-}
-
 static inline const char *sd_strerror(int err)
 {
 	int i;



More information about the sheepdog mailing list