[sheepdog] [PATCH 1/3] sheep: handle epoch_log_read errors in snap_file_write

Christoph Hellwig hch at infradead.org
Thu Jun 7 10:53:53 CEST 2012


On Thu, Jun 07, 2012 at 04:44:20PM +0800, Liu Yuan wrote:
> But if we already see the problem, we only need to fix it once. You
> added one fix in the previous patch and then removed the lines added in
> the next fix, and these two fixes happen one after another, I don't
> think there is any point doing so, unless there is a huge change for
> rebasing. Rebase next fix would cost you less than a minute, so I think
> we'd better rebase it rather than lazy applying first one which is
> removed by subsequent one.

Rebasing it is a pain, and the wrong thing to do.  There is absolutely
no reason to merge a small fix into a large cleanup.

I'm not going to rebase this series. If you don't want to apply both
please apply the fix and drop the cleanups.




More information about the sheepdog mailing list